Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758191Ab1DYJb4 (ORCPT ); Mon, 25 Apr 2011 05:31:56 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:34587 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758136Ab1DYJbz (ORCPT ); Mon, 25 Apr 2011 05:31:55 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 From: KOSAKI Motohiro To: KOSAKI Motohiro Subject: [PATCH 3/4] blackfin: don't touch task->cpus_allowed directly Cc: kosaki.motohiro@jp.fujitsu.com, Michael Hennerich , device-driver-devel@blackfin.uclinux.org, LKML , Andrew Morton In-Reply-To: <20110425182906.2673.A69D9226@jp.fujitsu.com> References: <20110425182906.2673.A69D9226@jp.fujitsu.com> Message-Id: <20110425183328.267F.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.56.05 [ja] Date: Mon, 25 Apr 2011 18:31:53 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1439 Lines: 42 Every callter (except kthread_bind) should use proper set_cpus_allowed_ptr() APIs. Signed-off-by: KOSAKI Motohiro Cc: Michael Hennerich Cc: device-driver-devel@blackfin.uclinux.org --- I'm curious why this mysterious code is necessary. Why sys_clone() restrict allowed cpus automatically and why don't it restore the restriction when do_fork() is finished. arch/blackfin/kernel/process.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/blackfin/kernel/process.c b/arch/blackfin/kernel/process.c index b407bc8..6a660fa 100644 --- a/arch/blackfin/kernel/process.c +++ b/arch/blackfin/kernel/process.c @@ -171,10 +171,8 @@ asmlinkage int bfin_clone(struct pt_regs *regs) unsigned long newsp; #ifdef __ARCH_SYNC_CORE_DCACHE - if (current->rt.nr_cpus_allowed == num_possible_cpus()) { - current->cpus_allowed = cpumask_of_cpu(smp_processor_id()); - current->rt.nr_cpus_allowed = 1; - } + if (current->rt.nr_cpus_allowed == num_possible_cpus()) + set_cpus_allowed_ptr(current, cpumask_of(smp_processor_id())); #endif /* syscall2 puts clone_flags in r0 and usp in r1 */ -- 1.7.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/