DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=sender:date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:in-reply-to:user-agent;
        b=jAS88ERtIgizkTS2BhKdFM9WplhM7m3SaAczyKQGlEEW6MbLH2QSgbJaure2ha6frn
         vgzeAvbK0cQSPfwatJ8ULiygKz7Lp5eoW7b4JR5Wi4ziRdR1cpHIAS7o7/N2chwbS8qT
         LISPkwvHfedPEj2Ubmm1o1sED32D1HxUgN+8Q=
Date: Mon, 25 Apr 2011 12:52:29 +0200
From: Tejun Heo <tj@kernel.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Nikita V. Youshchenko" <nyoushchenko@mvista.com>,
        Matt Fleming <matt@console-pimps.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/7] signal: retarget_shared_pending: consider
 shared/unblocked signals only
Message-ID: <20110425105229.GE17734@mtj.dyndns.org>
References: <20110418134421.GA15951@redhat.com>
 <20110418134501.GC15951@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110418134501.GC15951@redhat.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 716
Lines: 21

On Mon, Apr 18, 2011 at 03:45:01PM +0200, Oleg Nesterov wrote:
> -static void retarget_shared_pending(struct task_struct *tsk)
> +static void retarget_shared_pending(struct task_struct *tsk, sigset_t *set)

Hmm... @set?  Maybe a name which refelcts its purpose, say @target or
@consider would be better?  Also, it would be really great to have
docbook function comment describing the parameter.

Other than that,

 Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/