Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758836Ab1DYTkV (ORCPT ); Mon, 25 Apr 2011 15:40:21 -0400 Received: from out02.mta.xmission.com ([166.70.13.232]:41694 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755731Ab1DYTkT (ORCPT ); Mon, 25 Apr 2011 15:40:19 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: Borislav Petkov Cc: Ingo Molnar , "H. Peter Anvin" , Thomas Gleixner , Tony Luck , EDAC devel , LKML , Prarit Bhargava , Nagananda Chumbalkar , Russ Anderson Subject: Re: [PATCH -v2 2/2] x86, MCE: Drop the default decoding notifier References: <1303135222-17118-2-git-send-email-bp@amd64.org> <20110419171340.GE6640@elte.hu> <20110419173521.GA25374@aftab> <20110419174446.GA13616@elte.hu> <20110420102349.GB1361@aftab> Date: Mon, 25 Apr 2011 12:40:11 -0700 In-Reply-To: <20110420102349.GB1361@aftab> (Borislav Petkov's message of "Wed, 20 Apr 2011 12:23:49 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-XM-SPF: eid=;;;mid=;;;hst=in01.mta.xmission.com;;;ip=98.207.153.68;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX184icBnGOs7afpy06kCQ38CZU9FLteJou8= X-SA-Exim-Connect-IP: 98.207.153.68 X-SA-Exim-Mail-From: ebiederm@xmission.com X-SA-Exim-Scanned: No (on in01.mta.xmission.com); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1845 Lines: 46 Borislav Petkov writes: > On Tue, Apr 19, 2011 at 01:44:46PM -0400, Ingo Molnar wrote: >> >> * Borislav Petkov wrote: >> >> > + if (ret != NOTIFY_STOP) >> > + printk_ratelimited(KERN_EMERG HW_ERR >> > + "Run the above through 'mcelog --ascii'\n"); >> >> pr_emerg_ratelimited() would allow you to keep that broken line happy? > > Not entirely. I had to do the exit-early-to-save-an-indentation-level > trick also :) > > -- > From: Borislav Petkov > Date: Wed, 13 Apr 2011 14:32:06 +0200 > Subject: [PATCH -v2.1 2/2] x86, MCE: Drop the default decoding notifier > > The default notifier doesn't make a lot of sense to call in the > correctable errors case. Drop it and emit the mcelog decoding hint only > in the uncorrectable errors case and when no notifier is registered. > Also, limit issuing the "mcelog --ascii" message in the rare case when > we dump unreported CEs before panicking. > > While at it, remove unused old x86_mce_decode_callback from the > header. Can we please print something if we please log something in the case of a correctable error, when we only report it via mcelog? I have a stupid recent intel cpu here that hits that case and without the default x86_mce_decode_callback I wouldn't have even known that I am getting something like 50 correctable errors an hour on one of my machines. In particular I am it hits so often I am seeing: "mce_notify_irq: 2 callbacks suppressed". I need to get those dimms replaced soon because in a new product I simply can't imagine that many correctable errors. Eric -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/