Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756586Ab1DYWt2 (ORCPT ); Mon, 25 Apr 2011 18:49:28 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:59722 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753255Ab1DYWt1 (ORCPT ); Mon, 25 Apr 2011 18:49:27 -0400 Date: Mon, 25 Apr 2011 15:48:35 -0700 From: Andrew Morton To: Mike Travis Cc: Ingo Molnar , Yinghai Lu , "H. Peter Anvin" , Jack Steiner , Thomas Gleixner , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] memblock: add error return when CONFIG_HAVE_MEMBLOCK is not set Message-Id: <20110425154835.7d41d89e.akpm@linux-foundation.org> In-Reply-To: <20110425181136.211858618@gulag1.americas.sgi.com> References: <20110425181136.055235992@gulag1.americas.sgi.com> <20110425181136.211858618@gulag1.americas.sgi.com> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 786 Lines: 20 On Mon, 25 Apr 2011 13:11:37 -0500 Mike Travis wrote: > Add an error return if CONFIG_HAVE_MEMBLOCK is not set instead > of having to add #ifdef CONFIG_HAVE_MEMBLOCK around blocks of > code calling that function. > > Authored-by: Yinghai Lu > Signed-off-by: Mike Travis There is no such thing as "Authored-by:". If this patch was written by yinghai then it must be tagged as From:him at the top of the changelog and preferably has his signed-off-by: at the end. Please clarify? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/