Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758053Ab1DZDOI (ORCPT ); Mon, 25 Apr 2011 23:14:08 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:53639 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757787Ab1DZDOH (ORCPT ); Mon, 25 Apr 2011 23:14:07 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 From: KOSAKI Motohiro To: Dave Young Subject: Re: [PATCH] use oom_killer_disabled in all oom pathes Cc: kosaki.motohiro@jp.fujitsu.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org In-Reply-To: References: <20110426115902.F374.A69D9226@jp.fujitsu.com> Message-Id: <20110426121555.F378.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Mailer: Becky! ver. 2.56.05 [ja] Date: Tue, 26 Apr 2011 12:14:04 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1010 Lines: 26 > On Tue, Apr 26, 2011 at 10:57 AM, KOSAKI Motohiro > wrote: > >> oom_killer_disable should be a global switch, also fit for oom paths > >> other than __alloc_pages_slowpath > >> > >> Here add it to mem_cgroup_handle_oom and pagefault_out_of_memory as well. > > > > Can you please explain more? Why should? Now oom_killer_disabled is used > > only hibernation path. so, Why pagefault and memcg allocation will be happen? > > Indeed I'm using it in virtio balloon test, oom killer triggered when > memory pressure is high. > > literally oom_killer_disabled scope should be global, isn't it? ok. virtio baloon seems fair usage. if you add new usage of oom_killer_disabled into the patch description, I'll ack this one. thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/