Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758090Ab1DZDX4 (ORCPT ); Mon, 25 Apr 2011 23:23:56 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:35907 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757935Ab1DZDXz (ORCPT ); Mon, 25 Apr 2011 23:23:55 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Date: Tue, 26 Apr 2011 12:17:19 +0900 From: KAMEZAWA Hiroyuki To: Dave Young Cc: KOSAKI Motohiro , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] use oom_killer_disabled in all oom pathes Message-Id: <20110426121719.95894bc5.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: References: <20110426115902.F374.A69D9226@jp.fujitsu.com> <20110426121555.F378.A69D9226@jp.fujitsu.com> Organization: FUJITSU Co. LTD. X-Mailer: Sylpheed 3.1.0 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1458 Lines: 38 On Tue, 26 Apr 2011 11:19:22 +0800 Dave Young wrote: > On Tue, Apr 26, 2011 at 11:14 AM, KOSAKI Motohiro > wrote: > >> On Tue, Apr 26, 2011 at 10:57 AM, KOSAKI Motohiro > >> wrote: > >> >> oom_killer_disable should be a global switch, also fit for oom paths > >> >> other than __alloc_pages_slowpath > >> >> > >> >> Here add it to mem_cgroup_handle_oom and pagefault_out_of_memory as well. > >> > > >> > Can you please explain more? Why should? Now oom_killer_disabled is used > >> > only hibernation path. so, Why pagefault and memcg allocation will be happen? > >> > >> Indeed I'm using it in virtio balloon test, oom killer triggered when > >> memory pressure is high. > >> > >> literally oom_killer_disabled scope should be global, isn't it? > > > > ok. virtio baloon seems fair usage. if you add new usage of oom_killer_disabled > > into the patch description, I'll ack this one. > > Thanks, then I will resend the virtio balloon patch along with this. > Amount of free memory doesn't affect memory cgroup's OOM because it just works against the limit. So, the code for memcg isn't necessary. Thanks, -Kame -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/