Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754031Ab1DZK2I (ORCPT ); Tue, 26 Apr 2011 06:28:08 -0400 Received: from arkanian.console-pimps.org ([212.110.184.194]:60141 "EHLO arkanian.console-pimps.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753348Ab1DZK2G (ORCPT ); Tue, 26 Apr 2011 06:28:06 -0400 Date: Tue, 26 Apr 2011 11:28:04 +0100 From: Matt Fleming To: Oleg Nesterov Cc: Linus Torvalds , Andrew Morton , Tejun Heo , "Nikita V. Youshchenko" , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] signal: introduce do_sigtimedwait() to factor out compat/native code Message-ID: <20110426112804.6bd0713b@mfleming-mobl1.ger.corp.intel.com> In-Reply-To: <20110423175940.GC484@redhat.com> References: <20110418134421.GA15951@redhat.com> <20110418173224.GA27918@redhat.com> <20110423175901.GA484@redhat.com> <20110423175940.GC484@redhat.com> X-Mailer: Claws Mail 3.7.8cvs52 (GTK+ 2.22.0; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 886 Lines: 23 On Sat, 23 Apr 2011 19:59:40 +0200 Oleg Nesterov wrote: > Factor out the common code in sys_rt_sigtimedwait/compat_sys_rt_sigtimedwait > to the new helper, do_sigtimedwait(). > > Perhaps it would be better to move compat_sys_rt_sigtimedwait() into > signal.c under CONFIG_COMPAT, then we can make do_sigtimedwait() static. > > Signed-off-by: Oleg Nesterov Reviewed-by: Matt Fleming The changes Tejun suggested seem like a good idea. I also think that moving compat_sys_rt_sigtimedwait() into signal.c makes sense. -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/