Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754273Ab1DZKqk (ORCPT ); Tue, 26 Apr 2011 06:46:40 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:60122 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753957Ab1DZKqj (ORCPT ); Tue, 26 Apr 2011 06:46:39 -0400 Date: Tue, 26 Apr 2011 11:46:36 +0100 From: Mark Brown To: Ben Gardiner Cc: Liam Girdwood , alsa-devel@alsa-project.org, Jaroslav Kysela , Takashi Iwai , Sekhar Nori , davinci-linux-open-source@linux.davincidsp.com, James Nuss , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] davinci-mcasp: correct tdm_slots limit Message-ID: <20110426104635.GA13252@opensource.wolfsonmicro.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Cookie: Cold hands, no gloves. User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 667 Lines: 13 On Thu, Apr 21, 2011 at 02:19:01PM -0400, Ben Gardiner wrote: > The current check for the number of tdm-slots specified by platform data is > always true (x >= 2 || x <= 32); therefore the else branch that warns of an > incorrect number of slots can never be taken. Applied all of these. Please always try to ensure that your commit logs are consistent with the rest of the subsystem so they don't need to be rewritten. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/