Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755545Ab1DZNUx (ORCPT ); Tue, 26 Apr 2011 09:20:53 -0400 Received: from na3sys009aog105.obsmtp.com ([74.125.149.75]:32971 "EHLO na3sys009aog105.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755527Ab1DZNUw convert rfc822-to-8bit (ORCPT ); Tue, 26 Apr 2011 09:20:52 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=nanometrics.ca; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=kjs1mOa8CR7t2ul3Gi+3bPCoNawZgx5On71jWvVx36KNz9CchbwNscHQRG/NcUS2/d x9FUZjYD/bustTTx1pDvFXXqKmbJkslw2jIWVDF3SXHC/gHR0TOxzw4F3WQ2xGZRSRZO uMAuitNUPsvkdYlDq6AcCipECf+TwK1NknXvA= MIME-Version: 1.0 In-Reply-To: <20110426104635.GA13252@opensource.wolfsonmicro.com> References: <20110426104635.GA13252@opensource.wolfsonmicro.com> Date: Tue, 26 Apr 2011 09:20:50 -0400 Message-ID: Subject: Re: [PATCH 1/4] davinci-mcasp: correct tdm_slots limit From: Ben Gardiner To: Mark Brown Cc: Liam Girdwood , alsa-devel@alsa-project.org, Jaroslav Kysela , Takashi Iwai , Sekhar Nori , davinci-linux-open-source@linux.davincidsp.com, James Nuss , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1042 Lines: 26 On Tue, Apr 26, 2011 at 6:46 AM, Mark Brown wrote: > On Thu, Apr 21, 2011 at 02:19:01PM -0400, Ben Gardiner wrote: >> The current check for the number of tdm-slots specified by platform data is >> always true (x >= 2 || x <= 32); therefore the else branch that warns of an >> incorrect number of slots can never be taken. > > Applied all of these. ?Please always try to ensure that your commit logs > are consistent with the rest of the subsystem so they don't need to be > rewritten. Thanks, Mark, for taking the patches anyways (and Liam for the Ack's) -- Sorry I forgot the 'ASoC' tag (I noticed this patch was committed as 049cfaa ASoC: davinci-mcasp: correct tdm_slots limit). Best Regards, Ben Gardiner --- Nanometrics Inc. http://www.nanometrics.ca -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/