Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751670Ab1DZShN (ORCPT ); Tue, 26 Apr 2011 14:37:13 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.183]:37913 "EHLO ironport2-out.pppoe.ca" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751016Ab1DZShM (ORCPT ); Tue, 26 Apr 2011 14:37:12 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApIBAFEQt01Ld/sX/2dsb2JhbAAMhEbXKpFKgSmBWYF3fQSVJIdZ X-IronPort-AV: E=Sophos;i="4.64,270,1301889600"; d="scan'208";a="111568103" Message-ID: <4DB710D5.6060901@teksavvy.com> Date: Tue, 26 Apr 2011 14:37:09 -0400 From: Mark Lord User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.9.2.15) Gecko/20110303 Thunderbird/3.1.9 MIME-Version: 1.0 To: Bruce Stenning , Tejun Heo CC: "linux-kernel@vger.kernel.org" , "linux-ide@vger.kernel.org" Subject: Re: sata_mv port lockup on hotplug (kernel 2.6.38.2) References: <4D9CD275.9000002@teksavvy.com> <4D9FACC9.7020200@teksavvy.com> <4DA45CA7.9040102@teksavvy.com> <4DA467FB.6020905@teksavvy.com> <20110423005610.GC1576@mtj.dyndns.org> <20110425162242.GB30828@mtj.dyndns.org> <20110426135027.GI878@htj.dyndns.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1008 Lines: 27 On 11-04-26 11:41 AM, Bruce Stenning wrote: > Tejun wrote: >> Does the following patch resolve the problem? >> >> Thanks. > > I have applied that patch, keeping Mark's mv_set_main_irq_mask spinlock patch > in place. I would not like to commit absolutely, for obvious reasons, but I > have abused the port considerably and have not been able to coax it into > locking up. I'm thinking perhaps I should dust off that spinlock patch and send something more proper like that upstream. With that mask register shared among the ports, it is really hard to keep track of when we're locked and when not. So having a lock just for the shared part of the chip has got to be a less error-prone way to do it. I'll pull down a recent -git to patch against first. Cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/