Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755604Ab1DZTkO (ORCPT ); Tue, 26 Apr 2011 15:40:14 -0400 Received: from zone0.gcu-squad.org ([212.85.147.21]:18589 "EHLO services.gcu-squad.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751191Ab1DZTkM (ORCPT ); Tue, 26 Apr 2011 15:40:12 -0400 Date: Tue, 26 Apr 2011 21:39:53 +0200 From: Jean Delvare To: guenter.roeck@ericsson.com Cc: Len Brown , LKML , Rene Herman Subject: Re: [PATCH v2 3/3] thermal: Make THERMAL_HWMON implementation fully internal Message-ID: <20110426213953.6cc227de@endymion.delvare> In-Reply-To: <1303839812.31666.98.camel@groeck-laptop> References: <20110426165600.1d9ac91b@endymion.delvare> <20110426170407.3694e430@endymion.delvare> <20110426155212.GB18176@ericsson.com> <20110426182905.72bbf7b6@endymion.delvare> <1303839812.31666.98.camel@groeck-laptop> X-Mailer: Claws Mail 3.7.5 (GTK+ 2.20.1; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1496 Lines: 36 Hi Guenter, On Tue, 26 Apr 2011 10:43:32 -0700, Guenter Roeck wrote: > On Tue, 2011-04-26 at 12:29 -0400, Jean Delvare wrote: > > On Tue, 26 Apr 2011 08:52:12 -0700, Guenter Roeck wrote: > > > On Tue, Apr 26, 2011 at 11:04:07AM -0400, Jean Delvare wrote: > > > > * Removal code path is untested, as I have never been able to unload > > > > the thermal_sys module on any of my systems. Something is pinning it > > > > and I have no idea what it is. > > > > > > > Doesn't lsmod show the culprit ? > > > > No, it's not a module dependency. The reference counter is set to 1, Sorry I realize I have been inaccurate. thermal_sys indeed depends on the processor module, and that's what prevents me from unloading it. It's the processor module which has a reference count of 1, and no dependency, so I have no idea how I could unload it. > > so somewhere in the kernel something is taking a reference to the > > module and won't release it. I wish this was better instrumented so > > that it would be possible to know who is doing that. > > The most likely culprit seems to be acpi. I'm not sure. I don't see any relevant call to try_module_get under drivers/acpi, and I'm not aware of any other way to increase the reference count. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/