Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756151Ab1DZTp7 (ORCPT ); Tue, 26 Apr 2011 15:45:59 -0400 Received: from mail-yx0-f174.google.com ([209.85.213.174]:60931 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752515Ab1DZTp6 (ORCPT ); Tue, 26 Apr 2011 15:45:58 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=UxAs14mIuZWh7/zMUqXqL/mf0p7Z7GJhQbWpVPMjixm8T9/9sLQasF+O/0tvKsg5kT AqG9zZh44hMZGvnk1FSCemFxsDtHEb47oaarXimoZ8p1evBcSeuVl1kJKHqXYMPRZ5a2 GecurpAFejgodFYJtFfC5wfrElVOwCVOYsPDg= From: Thiago Farina To: linux-kernel@vger.kernel.org Cc: Steven Rostedt , Alexey Dobriyan , Thiago Farina Subject: [PATCH] linux/string.h: Introduce streq macro. Date: Tue, 26 Apr 2011 16:45:36 -0300 Message-Id: X-Mailer: git-send-email 1.7.5.rc2.5.g60e19 In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1386 Lines: 48 This macro is arguably more readable than its variants: - !strcmp(a, b) - strcmp(a, b) == 0 Signed-off-by: Thiago Farina --- Changes from v1 (Steven and Alexey review): - Convert from macro to static inline. - Remove the example. - Add the suggested comment by Steven. include/linux/string.h | 15 +++++++++++++++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/include/linux/string.h b/include/linux/string.h index a716ee2..d859bb2 100644 --- a/include/linux/string.h +++ b/include/linux/string.h @@ -134,6 +134,21 @@ extern ssize_t memory_read_from_buffer(void *to, size_t count, loff_t *ppos, const void *from, size_t available); /** + * streq - Are two strings equal? + * @a: first string + * @b: second string + * + * Use: streq(a, b) + * Instead of: strcmp(a, b) == 0 or !strcmp(a, b) + * + * This makes the code more readable and less error prone. + */ +static inline int streq(const char *a, const char *b) +{ + return strcmp(a, b) == 0; +} + +/** * strstarts - does @str start with @prefix? * @str: string to examine * @prefix: prefix to look for. -- 1.7.5.rc2.5.g60e19 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/