Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932861Ab1DZVe7 (ORCPT ); Tue, 26 Apr 2011 17:34:59 -0400 Received: from mga09.intel.com ([134.134.136.24]:58780 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758698Ab1DZVN5 (ORCPT ); Tue, 26 Apr 2011 17:13:57 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.64,270,1301900400"; d="scan'208";a="738831670" From: Andi Kleen References: <20110426212.641772347@firstfloor.org> In-Reply-To: <20110426212.641772347@firstfloor.org> To: huewe.external.infineon@googlemail.com, huewe.external@infineon.com, m.selhorst@sirrix.com, ak@linux.intel.com, torvalds@linux-foundation.org, gregkh@suse.de, linux-kernel@vger.kernel.org, stable@kernel.org, tim.bird@am.sony.com Subject: [PATCH] [29/106] char/tpm: Fix unitialized usage of data buffer Message-Id: <20110426211308.462513E1886@tassilo.jf.intel.com> Date: Tue, 26 Apr 2011 14:13:08 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1620 Lines: 41 2.6.35-longterm review patch. If anyone has any objections, please let me know. ------------------ From: Peter Huewe commit 1309d7afbed112f0e8e90be9af975550caa0076b upstream. This patch fixes information leakage to the userspace by initializing the data buffer to zero. Reported-by: Peter Huewe Signed-off-by: Peter Huewe Signed-off-by: Marcel Selhorst Signed-off-by: Andi Kleen [ Also removed the silly "* sizeof(u8)". If that isn't 1, we have way deeper problems than a simple multiplication can fix. - Linus ] Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- drivers/char/tpm/tpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.35.y/drivers/char/tpm/tpm.c =================================================================== --- linux-2.6.35.y.orig/drivers/char/tpm/tpm.c +++ linux-2.6.35.y/drivers/char/tpm/tpm.c @@ -970,7 +970,7 @@ int tpm_open(struct inode *inode, struct return -EBUSY; } - chip->data_buffer = kmalloc(TPM_BUFSIZE * sizeof(u8), GFP_KERNEL); + chip->data_buffer = kzalloc(TPM_BUFSIZE, GFP_KERNEL); if (chip->data_buffer == NULL) { clear_bit(0, &chip->is_open); put_device(chip->dev); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/