Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753753Ab1DZXJz (ORCPT ); Tue, 26 Apr 2011 19:09:55 -0400 Received: from smtp-out.google.com ([74.125.121.67]:1746 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751337Ab1DZXJx (ORCPT ); Tue, 26 Apr 2011 19:09:53 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=google.com; s=beta; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version:content-type; b=pszdjerQKRQGCLesMqExJSelDJuB/yUSPEbSVDrJD6g7XxCfjajMW/yyyXTYn6t5fJ K3q7iHgvKgu4FmvT7NEg== Date: Tue, 26 Apr 2011 16:09:47 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Randy Dunlap cc: linux-kernel@vger.kernel.org, Andrew Morton , Peter Foley , Linus Torvalds Subject: Re: [PATCH 2/2] init/Kconfig: use if/endif to surround the EXPERT menu kconfig symbols In-Reply-To: <20110426130036.997a05fc.rdunlap@xenotime.net> Message-ID: References: <20110426130036.997a05fc.rdunlap@xenotime.net> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1606 Lines: 40 On Tue, 26 Apr 2011, Randy Dunlap wrote: > From: Randy Dunlap > > Surround the EXPERT menu with "if EXPERT" and "endif" so that it > is forced to stay as one unit. Hopefully this will help to prevent > it being broken in the future. > > Signed-off-by: Randy Dunlap > Cc: David Rientjes > Cc: Peter Foley > --- > init/Kconfig | 36 ++++++++++++++++++++---------------- > 1 file changed, 20 insertions(+), 16 deletions(-) > > --- lnx-2639-rc4.orig/init/Kconfig > +++ lnx-2639-rc4/init/Kconfig > @@ -924,15 +924,17 @@ menuconfig EXPERT > environments which can tolerate a "non-standard" kernel. > Only use this if you really know what you are doing. > > +if EXPERT > + > config UID16 > - bool "Enable 16-bit UID system calls" if EXPERT > + bool "Enable 16-bit UID system calls" > depends on ARM || BLACKFIN || CRIS || FRV || H8300 || X86_32 || M68K || (S390 && !64BIT) || SUPERH || SPARC32 || (SPARC64 && COMPAT) || UML || (X86_64 && IA32_EMULATION) > default y > help > This enables the legacy 16-bit UID syscall wrappers. > I don't like this, people who look up a Kconfig option typically only look at the single entry and look for dependencies within it, not the context in which it is declared in the Kconfig file. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/