Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754673Ab1D0ISi (ORCPT ); Wed, 27 Apr 2011 04:18:38 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:45637 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752973Ab1D0ISg (ORCPT ); Wed, 27 Apr 2011 04:18:36 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Date: Wed, 27 Apr 2011 17:11:57 +0900 From: KAMEZAWA Hiroyuki To: Minchan Kim Cc: Andrew Morton , linux-mm , LKML , Christoph Lameter , Johannes Weiner , KOSAKI Motohiro , Mel Gorman , Rik van Riel , Andrea Arcangeli Subject: Re: [RFC 4/8] Make clear description of putback_lru_page Message-Id: <20110427171157.3751528f.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: References: Organization: FUJITSU Co. LTD. X-Mailer: Sylpheed 3.1.0 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1040 Lines: 27 On Wed, 27 Apr 2011 01:25:21 +0900 Minchan Kim wrote: > Commonly, putback_lru_page is used with isolated_lru_page. > The isolated_lru_page picks the page in middle of LRU and > putback_lru_page insert the lru in head of LRU. > It means it could make LRU churning so we have to be very careful. > Let's clear description of putback_lru_page. > > Cc: KOSAKI Motohiro > Cc: Mel Gorman > Cc: Rik van Riel > Cc: Andrea Arcangeli > Signed-off-by: Minchan Kim seems good... Reviewed-by: KAMEZAWA Hiroyuki But is there consensus which side of LRU is tail? head? I always need to revisit codes when I see a word head/tail.... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/