Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755511Ab1D0JJe (ORCPT ); Wed, 27 Apr 2011 05:09:34 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:42535 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754822Ab1D0JJc (ORCPT ); Wed, 27 Apr 2011 05:09:32 -0400 Date: Wed, 27 Apr 2011 10:09:23 +0100 From: Russell King - ARM Linux To: Arnd Bergmann Cc: linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC] ARM DMA mapping TODO, v1 Message-ID: <20110427090923.GO17290@n2100.arm.linux.org.uk> References: <201104212129.17013.arnd@arndb.de> <20110427073514.GH17290@n2100.arm.linux.org.uk> <201104271056.49920.arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201104271056.49920.arnd@arndb.de> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1509 Lines: 28 On Wed, Apr 27, 2011 at 10:56:49AM +0200, Arnd Bergmann wrote: > We probably still need to handle both the coherent and noncoherent case > in each dma_map_ops implementation, at least for those combinations where > they matter (definitely the linear mapping). However, I think that using > dma_mapping_common.h would let us use an architecture-independent dma_map_ops > for the generic iommu code that Marek wants to introduce now. The 'do we have an iommu or not' question and the 'do we need to do cache coherency' question are two independent questions which are unrelated to each other. There are four unique but equally valid combinations. Pushing the cache coherency question down into the iommu stuff will mean that we'll constantly be fighting against the 'but this iommu works on x86' shite that we've fought with over block device crap for years. I have no desire to go there. What we need is a proper abstraction where the DMA ops can say whether they can avoid DMA cache handling (eg, swiotlb or dmabounce stuff) but default to DMA cache handling being the norm - and the DMA cache handling performed in the level above the DMA ops indirection. Anything else is asking for an endless stream of shite iommu stuff getting DMA cache handling wrong. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/