Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757902Ab1D0KTR (ORCPT ); Wed, 27 Apr 2011 06:19:17 -0400 Received: from mail-pw0-f46.google.com ([209.85.160.46]:54018 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757773Ab1D0KTP (ORCPT ); Wed, 27 Apr 2011 06:19:15 -0400 Message-ID: From: "Subhasish Ghosh" To: "Sergei Shtylyov" Cc: , , , , , "Kevin Hilman \(supporter:TI DAVINCI MACHIN...,commit_signer:15/17=88%\)" , "Russell King \(maintainer:ARM PORT\)" , "Michael Williamson \(commit_signer:6/17=35%\)" , "Cyril Chemparathy \(commit_signer:3/17=18%\)" , "Sergei Shtylyov \(commit_signer:2/17=12%\)" , "open list" References: <1303474109-6212-1-git-send-email-subhasish@mistralsolutions.com> <1303474109-6212-4-git-send-email-subhasish@mistralsolutions.com> <4DB6A736.3030609@mvista.com> <0A4FA4CFE83C4DD4BA36491027E93552@subhasishg> <4DB7EA5E.7000507@mvista.com> In-Reply-To: <4DB7EA5E.7000507@mvista.com> Subject: Re: [PATCH v4 03/11] da850: pruss platform specific additions. Date: Wed, 27 Apr 2011 15:49:52 +0530 Organization: Mistral Solutions MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=response Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal Importance: Normal X-Mailer: Microsoft Windows Live Mail 14.0.8117.416 X-MimeOLE: Produced By Microsoft MimeOLE V14.0.8117.416 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 890 Lines: 23 >>>> #include >>>> @@ -73,6 +75,7 @@ extern unsigned int da850_max_speed; >>>> #define DA8XX_DDR2_CTL_BASE 0xb0000000 >>>> #define DA8XX_ARM_RAM_BASE 0xffff0000 >>>> #define DA8XX_SHARED_RAM_BASE 0x80000000 >>>> +#define DA8XX_PRUSS_MEM_BASE 0x01C30000 > >>> Keep the list sorted please. Also, this macro doesn't seem used outside >>> devices-da8xx.c, so should be moved there... > >> SG - But would it not be better to have all device addresses at the same >> place. > > They are not at the same place already -- which is intentional. The > ones used locally in devices-da8xx.c should be #define'd there. SG -- Ok, Will do -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/