Date: Wed, 27 Apr 2011 08:05:07 -0700
From: Greg KH <gregkh@suse.de>
To: Oren Weil <oren.jer.weil@intel.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
        alan@linux.intel.com, david@woodhou.se
Subject: Re: [PATCH 1/8] staging/mei: PCI device and char driver support.
Message-ID: <20110427150507.GC24596@suse.de>
References: <1303900057-21694-1-git-send-email-oren.jer.weil@intel.com>
 <1303900057-21694-2-git-send-email-oren.jer.weil@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1303900057-21694-2-git-send-email-oren.jer.weil@intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 666
Lines: 18

On Wed, Apr 27, 2011 at 01:27:30PM +0300, Oren Weil wrote:
> contains module entries and PCI driver and char device
> definitions (using file_operations, pci_driver structs).

That's a very lame description.  Please be more verbous, like you did on
the 0/8 patch, that explains what this code is and how it is accessed.

Same goes for the other patches in this series, you need to explain
things more.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/