Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759500Ab1D0Qqn (ORCPT ); Wed, 27 Apr 2011 12:46:43 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:38190 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753280Ab1D0Qqm (ORCPT ); Wed, 27 Apr 2011 12:46:42 -0400 Date: Wed, 27 Apr 2011 17:46:39 +0100 From: Al Viro To: Thiago Farina Cc: linux-kernel@vger.kernel.org, Steven Rostedt Subject: Re: [PATCH] linux/string.h: Introduce streq macro. Message-ID: <20110427164639.GD9487@ZenIV.linux.org.uk> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 601 Lines: 13 On Tue, Apr 26, 2011 at 03:49:49PM -0300, Thiago Farina wrote: > This macro is arguably more readable than its variants: > - !strcmp(a, b) > - strcmp(a, b) == 0 Strongly NACKed. As far as I'm concerned, it's in the same shitbucket as bcopy(3), bzero(3) et.al. Use idiomatic C; extensions of that kind are *bad*, since new developers have to learn them. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/