Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757722Ab1D0Sdl (ORCPT ); Wed, 27 Apr 2011 14:33:41 -0400 Received: from terminus.zytor.com ([198.137.202.10]:51441 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757520Ab1D0Sdj (ORCPT ); Wed, 27 Apr 2011 14:33:39 -0400 Message-ID: <4DB86163.2070201@zytor.com> Date: Wed, 27 Apr 2011 11:33:07 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Thunderbird/3.1.9 MIME-Version: 1.0 To: Steven Rostedt CC: Thiago Farina , linux-kernel@vger.kernel.org, Alexey Dobriyan , Rusty Russell , Ingo Molnar , "David S. Miller" , Al Viro , "Ted Ts'o" , Christoph Hellwig Subject: Re: [PATCH] linux/string.h: Introduce streq macro. References: <1303926576.18763.75.camel@gandalf.stny.rr.com> In-Reply-To: <1303926576.18763.75.camel@gandalf.stny.rr.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 932 Lines: 31 On 04/27/2011 10:49 AM, Steven Rostedt wrote: > On Tue, 2011-04-26 at 16:45 -0300, Thiago Farina wrote: >> This macro is arguably more readable than its variants: >> - !strcmp(a, b) >> - strcmp(a, b) == 0 > > Actually, this was proposed way back in 2002 my Rusty and I did not see > anyone arguing against it. I wonder why it never was incorporated back > then? > > http://marc.info/?l=linux-kernel&m=103284339813100&w=2 > > [ added Cc's of some of those that replied to this thread ] > Because !strcmp() is idiomatic C. This is the same kind of stupidity as #define BEGIN { #define END } It doesn't matter if it is more readable *to you*... learn the language, please. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/