Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756796Ab1D0UVF (ORCPT ); Wed, 27 Apr 2011 16:21:05 -0400 Received: from mail.perches.com ([173.55.12.10]:1036 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755920Ab1D0UVD (ORCPT ); Wed, 27 Apr 2011 16:21:03 -0400 Subject: Re: [PATCH v3.2] kbuild: implement several W= levels From: Joe Perches To: Borislav Petkov Cc: Sam Ravnborg , Michal Marek , linux-kbuild , LKML , Dave Jones , Geert Uytterhoeven In-Reply-To: <1303935327-5154-1-git-send-email-bp@alien8.de> References: <20110427113513.GB18112@eferding.osrc.amd.com> <1303935327-5154-1-git-send-email-bp@alien8.de> Content-Type: text/plain; charset="UTF-8" Date: Wed, 27 Apr 2011 13:21:00 -0700 Message-ID: <1303935660.24299.76.camel@Joe-Laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 710 Lines: 21 On Wed, 2011-04-27 at 22:15 +0200, Borislav Petkov wrote: > From: Sam Ravnborg [] > +warning-1 += -Wold-style-definition > +warning-1 += $(call cc-option, -Wmissing-include-dirs) Only thing I would suggest is a comment describing why some entries use $(call cc-option, -Wfoo) and others don't. Something akin to: # Use call cc-option when the minimum supported gcc version does not # support a specific option but a later gcc version does. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/