Subject: Re: [RFC] ARM DMA mapping TODO, v1
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Arnd Bergmann <arnd@arndb.de>, linux-arm-kernel@lists.infradead.org,
        linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org
In-Reply-To: <20110427202603.GY17290@n2100.arm.linux.org.uk>
References: <201104212129.17013.arnd@arndb.de>
	 <201104271302.44249.arnd@arndb.de>
	 <20110427201605.GW17290@n2100.arm.linux.org.uk>
	 <201104272221.48601.arnd@arndb.de>
	 <20110427202603.GY17290@n2100.arm.linux.org.uk>
Content-Type: text/plain; charset="UTF-8"
Date: Thu, 28 Apr 2011 07:41:07 +1000
Message-ID: <1303940467.2513.188.camel@pasglop>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 949
Lines: 27


> As I said above, I don't think bus code can do it.  Take my example
> above of a tulip pci device on x86 and a tulip pci device on ARM.  Both
> use the same PCI code.
> 
> Maybe something in asm/pci.h - but that invites having lots of bus
> specific header files in asm/.
> 
> A better solution imho would be to have an architecture callback for
> struct device which gets registered, which can inspect the type of
> the device, and set the flag depending on where it appears in the
> tree.

Now -that's gross :-)

For PCI you can have the flag propagate from the PHB down, for busses
without a bus type (platform) then whoever instanciate them (the
platform code) can set that appropriately.

Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/