Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755422Ab1D0WUF (ORCPT ); Wed, 27 Apr 2011 18:20:05 -0400 Received: from www.linutronix.de ([62.245.132.108]:44969 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752349Ab1D0WUE (ORCPT ); Wed, 27 Apr 2011 18:20:04 -0400 Date: Thu, 28 Apr 2011 00:19:55 +0200 (CEST) From: Thomas Gleixner To: john stultz cc: Alexander Shishkin , Andrew Morton , Chris Friesen , Kay Sievers , "Kirill A. Shutemov" , LKML , Peter Zijlstra , Davide Libenzi Subject: Re: [RFC][PATCH 1/4] clock_rtoffset: new syscall In-Reply-To: <1303931500.2971.14.camel@work-vm> Message-ID: References: <1303901023-11568-1-git-send-email-virtuoso@slind.org> <1303931500.2971.14.camel@work-vm> User-Agent: Alpine 2.02 (LFD 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1273 Lines: 38 On Wed, 27 Apr 2011, john stultz wrote: > On Wed, 2011-04-27 at 16:02 +0200, Thomas Gleixner wrote: > > On Wed, 27 Apr 2011, Alexander Shishkin wrote: > Overall looks good. I flinched a little bit at adding an internal only > clockid but trying to avoid that would really make it messy. Yes. It would. And we really don't want to mess with the POSIX interfaces. Having this extension and the weird return code for timerfd seems to be a reasonable limitation. > > +#ifdef __KERNEL__ > > +/* This clock is not exposed to user space */ > > +#define CLOCK_REALTIME_COS 8 > > +#endif > > Would something like INTERNAL_CLOCK_REALTIME_COS be more explicit? Yes. Good point. > > + base = cpu_base->clock_base + HRTIMER_BASE_REALTIME_COS; > > I know its the same thing, but for some reason the above makes me think > that the clock_base could be non-zero. > > base = &cpu_base->clock_base[HRTIMER_BASE_REALTIME_COS]; > > seems more straight forward to me. But its not a huge deal. I don't care either way :) Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/