Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751836Ab1D1JR2 (ORCPT ); Thu, 28 Apr 2011 05:17:28 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:48388 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750755Ab1D1JR0 (ORCPT ); Thu, 28 Apr 2011 05:17:26 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Date: Thu, 28 Apr 2011 18:10:46 +0900 From: KAMEZAWA Hiroyuki To: Johannes Weiner Cc: Minchan Kim , Andrew Morton , linux-mm , LKML , Christoph Lameter , Johannes Weiner , KOSAKI Motohiro , Mel Gorman , Rik van Riel , Andrea Arcangeli Subject: Re: [RFC 3/8] vmscan: make isolate_lru_page with filter aware Message-Id: <20110428181046.b81635ce.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20110428085432.GI12437@cmpxchg.org> References: <232562452317897b5acb1445803410d74233a923.1303833417.git.minchan.kim@gmail.com> <20110427170304.d31c1398.kamezawa.hiroyu@jp.fujitsu.com> <20110428085432.GI12437@cmpxchg.org> Organization: FUJITSU Co. LTD. X-Mailer: Sylpheed 3.1.0 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1587 Lines: 41 On Thu, 28 Apr 2011 10:54:32 +0200 Johannes Weiner wrote: > On Wed, Apr 27, 2011 at 05:03:04PM +0900, KAMEZAWA Hiroyuki wrote: > > On Wed, 27 Apr 2011 01:25:20 +0900 > > Minchan Kim wrote: > > > > > In some __zone_reclaim case, we don't want to shrink mapped page. > > > Nonetheless, we have isolated mapped page and re-add it into > > > LRU's head. It's unnecessary CPU overhead and makes LRU churning. > > > > > > Of course, when we isolate the page, the page might be mapped but > > > when we try to migrate the page, the page would be not mapped. > > > So it could be migrated. But race is rare and although it happens, > > > it's no big deal. > > > > > > Cc: Christoph Lameter > > > Cc: KOSAKI Motohiro > > > Cc: Mel Gorman > > > Cc: Rik van Riel > > > Cc: Andrea Arcangeli > > > Signed-off-by: Minchan Kim > > > > > > Hmm, it seems mm/memcontrol.c::mem_cgroup_isolate_pages() should be updated, too. > > memcg reclaim always does sc->may_unmap = 1. What is there to > communicate to mem_cgroup_isolate_pages? > Hmm, maybe you're right and nothing to do until memcg need to support soft limit in zone reclaim mode. I hope no more users. Thanks, -Kame -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/