Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932182Ab1D1Jfs (ORCPT ); Thu, 28 Apr 2011 05:35:48 -0400 Received: from 67-20-127-205.bluehost.com ([67.20.127.205]:37532 "EHLO mail.betterlinuxtesting.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753217Ab1D1Jfp (ORCPT ); Thu, 28 Apr 2011 05:35:45 -0400 Date: Thu, 28 Apr 2011 11:35:42 +0200 From: Andrea Righi To: Mike Frysinger Cc: Andrew Morton , Dave Chinner , Al Viro , Arnd Bergmann , linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] fadvise: introduce POSIX_FADV_DONTNEED_FS Message-ID: <20110428093542.GB2517@linux.develer.com> References: <1303928027-5100-1-git-send-email-andrea@betterlinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1760 Lines: 38 On Wed, Apr 27, 2011 at 02:25:17PM -0400, Mike Frysinger wrote: > On Wed, Apr 27, 2011 at 14:13, Andrea Righi wrote: > > Introduce a new fadvise flag to drop page cache pages of a single > > filesystem. > > > > At the moment it is possible to drop page cache pages via > > /proc/sys/vm/drop_pagecache or via posix_fadvise(POSIX_FADV_DONTNEED). > > > > The first method drops the whole page cache while the second can be used > > to drop page cache pages of a single file descriptor. However, there's > > not a simple way to drop all the pages of a filesystem (we could scan > > all the file descriptors and use posix_fadvise(POSIX_FADV_DONTNEED), but > > this solution obviously doesn't scale well). > > what if you open the mount point and use POSIX_FADV_DONTNEED on that > dir handle ? if you required write access for that level, it'd also > implicitly take care of the permission issue. but maybe this is just > trying to fit existing code in the wrong way. > -mike I still prefer the capability check. I think it's much more simple from the userspace point of view to be able to specify any file or directory instead of being forced to retrieve the mountpoint. However, an advantage with the approach you're proposing is that a non-privileged user can drop the page cache of a filesystem if it has write permission in the root of that filesystem. mmmh.. I don't see big problems also with the interface you propose, if you all think it's better I can implement this in the next version. Thanks, -Andrea -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/