Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932463Ab1D1Mq6 (ORCPT ); Thu, 28 Apr 2011 08:46:58 -0400 Received: from ozlabs.org ([203.10.76.45]:42411 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932396Ab1D1Mqz (ORCPT ); Thu, 28 Apr 2011 08:46:55 -0400 From: Rusty Russell To: Jan Glauber Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, castet.matthieu@free.fr, sliakh.lkml@gmail.com, jiang@cs.ncsu.edu, mingo@elte.hu Subject: Re: Undoing module RONX protection fix In-Reply-To: <1303985300.3495.93.camel@localhost.localdomain> References: <20110418092348.GB7786@hal> <20110418092801.GC3837@infradead.org> <874o5v6drb.fsf@rustcorp.com.au> <20110421141949.GA10675@hal> <87ipu0l1kt.fsf@rustcorp.com.au> <1303985300.3495.93.camel@localhost.localdomain> User-Agent: Notmuch/0.3.1 (http://notmuchmail.org) Emacs/23.1.1 (i686-pc-linux-gnu) Date: Thu, 28 Apr 2011 21:06:39 +0930 Message-ID: <87tyditxo8.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 873 Lines: 24 On Thu, 28 Apr 2011 12:08:20 +0200, Jan Glauber wrote: > How about this? > > To be honest I don't like the inverse naming like in unset no-execute > too much, it makes me feel dizzy. But I wanted to keep the changes > minimal. Yes, it should probably just be called protect_module_pages and unprotect_module_pages. The current names provide far too much information. But going back a bit, how did we end up with a NULL mod->module_init and yet module->init_text_size, mod->init_size or mod->init_ro_size non-zero? Because if start == end, set_page_attributes() is a noop, right? Confused, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/