Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933579Ab1D1XHT (ORCPT ); Thu, 28 Apr 2011 19:07:19 -0400 Received: from mail-qw0-f46.google.com ([209.85.216.46]:59945 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932595Ab1D1XGy convert rfc822-to-8bit (ORCPT ); Thu, 28 Apr 2011 19:06:54 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:content-transfer-encoding; b=KYUiU0LhBZpISdHTmG2U0/KBu3n8lSqrJQcvKKT+wbQymBfepIhMTNpRPJ0LMbUxJv s5wkOIPS05IY/WNUiEj/KkOAQ5UAia9VUFTUJ1/8Ft1EvKeT8bYb8q1WBDYNkAK1Pjvg /UfsWXYxg/i892GE03DveVNazHrZ03x15UubY= MIME-Version: 1.0 Reply-To: sedat.dilek@gmail.com In-Reply-To: References: <20110426112756.GF4308@linux.vnet.ibm.com> <20110426183859.6ff6279b@neptune.home> <20110426190918.01660ccf@neptune.home> <20110427081501.5ba28155@pluto.restena.lu> <20110427204139.1b0ea23b@neptune.home> <20110428102609.GJ2135@linux.vnet.ibm.com> <1303997401.7819.5.camel@marge.simson.net> <20110428222301.0b745a0a@neptune.home> <20110428224444.43107883@neptune.home> <1304027480.2971.121.camel@work-vm> Date: Fri, 29 Apr 2011 01:06:52 +0200 Message-ID: Subject: Re: 2.6.39-rc4+: Kernel leaking memory during FS scanning, regression? From: Sedat Dilek To: Thomas Gleixner Cc: john stultz , =?UTF-8?Q?Bruno_Pr=C3=A9mont?= , Mike Galbraith , "Paul E. McKenney" , Linus Torvalds , Ingo Molnar , Peter Zijlstra , Mike Frysinger , KOSAKI Motohiro , LKML , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, "Paul E. McKenney" , Pekka Enberg Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3396 Lines: 90 On Fri, Apr 29, 2011 at 12:02 AM, Thomas Gleixner wrote: > On Thu, 28 Apr 2011, john stultz wrote: >> On Thu, 2011-04-28 at 23:04 +0200, Thomas Gleixner wrote: >> > /me suspects hrtimer changes to be the real culprit. >> >> I'm not seeing anything on right off, but it does smell like >> e06383db9ec591696a06654257474b85bac1f8cb would be where such an issue >> would crop up. >> >> Bruno, could you try checking out e06383db9ec, confirming it still >> occurs (and then maybe seeing if it goes away at e06383db9ec^1)? >> >> I'll keep digging in the meantime. > > I found the bug already. The problem is that sched_init() calls > init_rt_bandwidth() which calls hrtimer_init() _BEFORE_ > hrtimers_init() is called. > > That was unnoticed so far as the CLOCK id to hrtimer base conversion > was hardcoded. Now we use a table which is set up at hrtimers_init(), > so the bandwith hrtimer ends up on CLOCK_REALTIME because the table is > in the bss. > > The patch below fixes this, by providing the table statically rather > than runtime initialized. Though that whole ordering wants to be > revisited. > > Thanks, > >        tglx > > --- linux-2.6.orig/kernel/hrtimer.c > +++ linux-2.6/kernel/hrtimer.c > @@ -81,7 +81,11 @@ DEFINE_PER_CPU(struct hrtimer_cpu_base, >        } >  }; > > -static int hrtimer_clock_to_base_table[MAX_CLOCKS]; > +static int hrtimer_clock_to_base_table[MAX_CLOCKS] = { > +       [CLOCK_REALTIME] = HRTIMER_BASE_REALTIME, > +       [CLOCK_MONOTONIC] = HRTIMER_BASE_MONOTONIC, > +       [CLOCK_BOOTTIME] = HRTIMER_BASE_BOOTTIME, > +}; > >  static inline int hrtimer_clockid_to_base(clockid_t clock_id) >  { > @@ -1722,10 +1726,6 @@ static struct notifier_block __cpuinitda > >  void __init hrtimers_init(void) >  { > -       hrtimer_clock_to_base_table[CLOCK_REALTIME] = HRTIMER_BASE_REALTIME; > -       hrtimer_clock_to_base_table[CLOCK_MONOTONIC] = HRTIMER_BASE_MONOTONIC; > -       hrtimer_clock_to_base_table[CLOCK_BOOTTIME] = HRTIMER_BASE_BOOTTIME; > - >        hrtimer_cpu_notify(&hrtimers_nb, (unsigned long)CPU_UP_PREPARE, >                          (void *)(long)smp_processor_id()); >        register_cpu_notifier(&hrtimers_nb); > > > Looks good so far, no stalls or call-traces. Really stressing with 20+ open tabs in firefox with flash-movie running in one of them , tar-job, IRC-client etc. I will run some more tests and collect data and send them later. - Sedat - P.S.: Patchset against linux-2.6-rcu.git#sedat.2011.04.23a where 0003 is from [2] [1] http://git.us.kernel.org/?p=linux/kernel/git/paulmck/linux-2.6-rcu.git;a=shortlog;h=refs/heads/sedat.2011.04.23a [2] https://patchwork.kernel.org/patch/739782/ $ l ../RCU-HOORAY/ insgesamt 40 drwxr-xr-x 2 sd sd 4096 29. Apr 01:02 . drwxr-xr-x 35 sd sd 20480 29. Apr 01:01 .. -rw-r--r-- 1 sd sd 726 29. Apr 01:01 0001-Revert-rcu-restrict-TREE_RCU-to-SMP-builds-with-PREE.patch -rw-r--r-- 1 sd sd 735 29. Apr 01:01 0002-sched-Add-warning-when-RT-throttling-is-activated.patch -rw-r--r-- 1 sd sd 2376 29. Apr 01:01 0003-2.6.39-rc4-Kernel-leaking-memory-during-FS-scanning-.patch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/