Date: Fri, 29 Apr 2011 02:38:55 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Vaibhav Nagarnaik <vnagarnaik@google.com>
cc: Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@redhat.com>,
        Michael Rubin <mrubin@google.com>, David Sharp <dhsharp@google.com>,
        linux-kernel@vger.kernel.org, x86@kernel.org,
        Aditya Kali <adityakali@google.com>
Subject: Re: [PATCH 2/2] x86: Change trap definitions to enumerated values
In-Reply-To: <1303513438-26519-2-git-send-email-vnagarnaik@google.com>
Message-ID: <alpine.LFD.2.02.1104290233490.3005@ionos>
References: <1303513438-26519-1-git-send-email-vnagarnaik@google.com> <1303513438-26519-2-git-send-email-vnagarnaik@google.com>
User-Agent: Alpine 2.02 (LFD 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 918
Lines: 26

On Fri, 22 Apr 2011, Vaibhav Nagarnaik wrote:

> From: Aditya Kali <adityakali@google.com>
> 
> The traps are referred to by their numbers and it can be difficult to
> understand them while reading the code without context. This patch adds
> enumeration of the trap numbers and replaced the numbers to the correct
> enum for x86.

I really like that patch, but it should have been 1/2 as it has a
value independent of the trap trace stuff.

And if you had done that, then the trap trace patch could have used
those symbols instead of the numbers as well.

Now that's the 2/2 patch and leaves the (not so) shiny new trace
points with those weird numbers. :(

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/