Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754691Ab1D2PID (ORCPT ); Fri, 29 Apr 2011 11:08:03 -0400 Received: from va3ehsobe001.messaging.microsoft.com ([216.32.180.11]:24358 "EHLO VA3EHSOBE001.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751697Ab1D2PIA (ORCPT ); Fri, 29 Apr 2011 11:08:00 -0400 X-SpamScore: -19 X-BigFish: VPS-19(zzbb2dK9371O1432N98dKzz1202hzz8275bhz2dh668h839h62h) X-Spam-TCS-SCL: 1:0 X-Forefront-Antispam-Report: KIP:(null);UIP:(null);IPVD:NLI;H:nwd2mail11.analog.com;RD:nwd2mail11.analog.com;EFVD:NLI X-IronPort-AV: E=Sophos;i="4.64,288,1301889600"; d="scan'208";a="32407576" Message-ID: <4DBAD21F.7040406@analog.com> Date: Fri, 29 Apr 2011 16:58:39 +0200 From: Michael Hennerich Organization: Analog Devices Inc. User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20101125 SUSE/3.0.11 Thunderbird/3.0.11 MIME-Version: 1.0 To: Jean-Francois Dagenais CC: Jonathan Cameron , Barry Song <21cnbao@gmail.com>, "linux-kernel@vger.kernel.org" , "device-drivers-devel@blackfin.uclinux.org" , "linux-input@vger.kernel.org" Subject: Re: ad714x driver help and possible bug References: <62821D7C-1637-4F7E-A53A-F52AEB2A6C87@gmail.com> <4DBA8AFE.6080807@cam.ac.uk> <4DBAD0AC.3010608@analog.com> In-Reply-To: <4DBAD0AC.3010608@analog.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-OriginatorOrg: analog.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1728 Lines: 48 On 04/29/2011 04:52 PM, Michael Hennerich wrote: > On 04/29/2011 11:55 AM, Jonathan Cameron wrote: >> Cc'd input, and analog devices driver list... >> >> On 04/28/11 19:17, Jean-Francois Dagenais wrote: >> >> >>> I also had to change the request_threaded_irq flags to specify >>> IRQF_ONESHOT so the kernel keeps the interrupt masked while we are >>> running ad714x_interrupt_thread(). Otherwise we were getting storms >>> of interrupts each time only one was requested. I am wondering if >>> this should be pulled back to the mainline kernel? >>> >>> Thanks for pointers and clues! >>> >>> > I assume this is due to the fact that the interrupt on the host is > level sensitive. > In this case you need to use the IRQF_ONESHOT flag. > The unmodified driver requests the IRQ as IRQF_TRIGGER_FALLING, so > this is not necessary. > > To my knowledge we regularly test the driver with the sliders, wheels > and buttons found on the > official evaluation board, and so far we haven't found oddities. > For an example platform file see: arch/blackfin/mach-bf537/boards/stamp.c > From top of my head I don't know whether we're testing with the SPI or > I2C interface. > > http://wiki.analog.com/software/driver/linux/ad714x > -- Greetings, Michael -- Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368; Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin, Margaret Seif -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/