Message-ID: <4DBB42F9.7070407@suse.cz>
Date: Sat, 30 Apr 2011 01:00:09 +0200
From: Michal Marek <mmarek@suse.cz>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; cs-CZ; rv:1.9.2.14) Gecko/20110221 SUSE/3.1.8 Thunderbird/3.1.8
MIME-Version: 1.0
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: pefoley2@verizon.net, linux-kernel@vger.kernel.org,
        linux-kbuild@vger.kernel.org
Subject: Re: [PATCH V2 0/7] kbuild: move scripts/basic/docproc.c to scripts/docproc.c
References: <4DBB3DD4.9000000@verizon.net> <20110429154649.848f9ba8.rdunlap@xenotime.net>
In-Reply-To: <20110429154649.848f9ba8.rdunlap@xenotime.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1734
Lines: 43

On 30.4.2011 00:46, Randy Dunlap wrote:
> On Fri, 29 Apr 2011 18:38:12 -0400 Peter Foley wrote:
> 
>> This patchset moves scripts/basic/docproc to scripts/docproc.
>> This causes docproc to only be built for *doc targets rather than every
>> time the kernel is compiled.
>>
>> Patches also attached as requested by Michal Marek.
> 
> 
> That's disappointing (the attachments).  Why was this requested?
> 
> See Documentation/CodingStyle, section 7:
> 
> "No MIME, no links, no compression, no attachments.  Just plain text."

and a couple of lines later:
"Exception:  If your mailer is mangling patches then someone may ask
you to re-send them using MIME."

Which is exactly what happened here - the patches had missing or excess
leading space and in some cases a context line was missing. So instead
of manually reconstructing the patches, I asked Peter to resend them as
attachments.

BUT - I didn't request to split this patch into seven pieces. Splitting
patches into smaller parts is desired, but each part has to be self
contained and not break stuff when the later parts are not applied. So
when moving a .c file, then the corespoding Makefile changes need to be
contained in the same patch. No need to resend the patch now, I'll fold
the patches into one again, but please consider this next time.

> Instead, the saved file contains lines like
> this (below) and each patch 2 times (inline and attachment).

Yeah, only sending the attachment would be better in this case.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/