Date: Fri, 29 Apr 2011 17:07:04 -0700
From: Greg KH <gregkh@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jan Kara <jack@suse.cz>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: Allow setting of number of raw devices as a module parameter
Message-ID: <20110430000704.GA3443@suse.de>
References: <1304029469-19672-1-git-send-email-jack@suse.cz>
 <20110429162817.2eb26efb.akpm@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110429162817.2eb26efb.akpm@linux-foundation.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1050
Lines: 27

On Fri, Apr 29, 2011 at 04:28:17PM -0700, Andrew Morton wrote:
> On Fri, 29 Apr 2011 00:24:29 +0200
> Jan Kara <jack@suse.cz> wrote:
> 
> > Allow setting of maximal number of raw devices as a module parameter. This
> > requires changing of static array into a vmalloced one (the array is going to
> > be too large for kmalloc).
> > 
> 
> Changelog failed to describe why the patch is needed.  Lacking that
> information, we have no reason to apply it.

Good point, how about:
	People like running their machines with thousands of raw
	devices, yet distros don't want to take up that much memory for
	all users.  Provide a way for everyone to be happy without
	forcing the module to be rebuilt by providing the ability to
	specify the number of raw devices as a module parameter option.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/