Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759538Ab1D3AOz (ORCPT ); Fri, 29 Apr 2011 20:14:55 -0400 Received: from smtp-out.google.com ([74.125.121.67]:11753 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754429Ab1D3AOx convert rfc822-to-8bit (ORCPT ); Fri, 29 Apr 2011 20:14:53 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=google.com; s=beta; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=AHSWzkFW5tzmt6vGEtFNow/DA1pmn46DzBwqNvDNDYKklkn3BVoOU2m1URIchXsLYn S2a+4kMLkLpbwtVLWiTg== MIME-Version: 1.0 In-Reply-To: <20110429234028.GA28476@kroah.com> References: <20110429212328.GA19207@kroah.com> <20110429225551.22013.65012.stgit@mike.mtv.corp.google.com> <20110429234028.GA28476@kroah.com> From: Mike Waychison Date: Fri, 29 Apr 2011 17:14:30 -0700 Message-ID: Subject: Re: [PATCH v4 1/3] driver: Google EFI SMI To: Greg KH Cc: Matt Domsch , Alan Cox , Duncan Laurie , Aaron Durbin , x86@kernel.org, linux-kernel@vger.kernel.org, Tim Hockin , San Mehat Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8BIT X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2294 Lines: 51 On Fri, Apr 29, 2011 at 4:40 PM, Greg KH wrote: > On Fri, Apr 29, 2011 at 03:55:51PM -0700, Mike Waychison wrote: >> The "gsmi" driver bridges userland with firmware specific routines for >> accessing hardware. >> >> Currently, this driver only supports NVRAM and eventlog information. >> Deprecated functions have been removed from the driver, though their >> op-codes are left in place so that they are not re-used. >> >> This driver works by trampolining into the firmware via the smi_command >> outlined in the FADT table. ?Three protocols are used due to various >> limitations over time, but all are included herein. >> >> This driver should only ever load on Google boards, identified by either >> a "Google, Inc." board vendor string in DMI, or "GOOGLE" in the OEM >> strings of the FADT ACPI table. ?This logic happens in >> gsmi_system_valid(). >> >> Signed-off-by: Duncan Laurie >> Signed-off-by: Aaron Durbin >> Signed-off-by: Mike Waychison > > {sigh} > > I now get this build error with this patch applied: > > ?CC [M] ?drivers/firmware/google/gsmi.o > drivers/firmware/google/gsmi.c: In function ?gsmi_die_callback?: > drivers/firmware/google/gsmi.c:660:16: error: ?DIE_NMIWATCHDOG? undeclared (first use in this function) > drivers/firmware/google/gsmi.c:660:16: note: each undeclared identifier is reported only once for each function it appears in > make[3]: *** [drivers/firmware/google/gsmi.o] Error 1 > > > Also, I had to hand edit the drivers/firmware/Makefile and Kconfig parts > of this patch to get it to apply, care to respin it against the > linux-next tree so I don't have to do that next time around? > Ya, I'm looking at these now. Hmm :( It seems the nmi watchdog got renamed to the 'hard lockup' detector, and we lost the DIE callback in the meantime. I think for the moment, I'm going to respin and drop the NMI bits for now. We can revisit actually calling notify_die() when we panic in watchdog_overflow_callback() as a follow on. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/