Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761200Ab1D3BxU (ORCPT ); Fri, 29 Apr 2011 21:53:20 -0400 Received: from aspirin.dii.utk.edu ([160.36.0.81]:36742 "EHLO aspirin.dii.utk.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761138Ab1D3BxT (ORCPT ); Fri, 29 Apr 2011 21:53:19 -0400 Date: Fri, 29 Apr 2011 21:53:04 -0400 (EDT) From: Vince Weaver To: Ingo Molnar cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, Peter Zijlstra , Stephane Eranian , Andi Kleen , Thomas Gleixner Subject: Re: re-enable Nehalem raw Offcore-Events support In-Reply-To: <20110429164227.GA25491@elte.hu> Message-ID: References: <20110429164227.GA25491@elte.hu> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 869 Lines: 28 On Fri, 29 Apr 2011, Ingo Molnar wrote: > Generalization of offcore, NUMA memory events is very much possible and > desirable, and Peter has posted an RFC patch that implements one form of it: > > https://lkml.org/lkml/2011/4/22/281 > OK, so I "reviewed" this patch. It creates a "generalized" new event, that is only actually available on Nehalem and Westmere. It's listed as unavailable for all other known architectures. How is this any better than just using the event by its actual name if you happen to have a Nehalem-esque chip? This is just pointless kernel bloat. So here's my review: NACK Vince -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/