Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757362Ab1D3DJk (ORCPT ); Fri, 29 Apr 2011 23:09:40 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:33752 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753339Ab1D3DJi convert rfc822-to-8bit (ORCPT ); Fri, 29 Apr 2011 23:09:38 -0400 MIME-Version: 1.0 In-Reply-To: <20110430030243.GJ9487@ZenIV.linux.org.uk> References: <20110430025545.GI9487@ZenIV.linux.org.uk> <20110430030243.GJ9487@ZenIV.linux.org.uk> From: Linus Torvalds Date: Fri, 29 Apr 2011 20:09:16 -0700 Message-ID: Subject: Re: 2.6.39-rc5-git2 boot crashs To: Al Viro Cc: Joern Engel , Dave Chinner , werner , Linux Kernel Mailing List Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1277 Lines: 28 On Fri, Apr 29, 2011 at 8:02 PM, Al Viro wrote: > > Wait a bit; _can_ we get there with non-NULL ->s_master_inode et.al.? > iput(NULL) is a noop... ?I don't think so, since logfs_init_journal() > is not called until after we initialize that list. > > Not that I'd object against taking that initialization earlier, of course, > but there seems to be something else going on... ?Which iput() it is? Not something I can guess from the oops, sadly. Gcc has inlined everything into logfs_mount, and the "0x44f/0x5cc" offset isn't very helpful (with the same compiler version and config options it would be possible to figure it out). But looking at it, logfs_init_mapping() is currently called before "s_freeing_list" is initialized, and it sets up at least s_mapping_inode. So if anything fails between that point and the point where we initialize s_freeing_list, I think we're toast. I didn't check the other inodes, but at least that one does seem to be potentially non-NULL. No? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/