Subject: Re: [RESEND PATCH 1/2] perf probe: Fix the missed parameter
 initialization
From: Lin Ming <ming.m.lin@intel.com>
To: Arnaldo Carvalho de Melo <acme@infradead.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
In-Reply-To: <20110429173332.GA3273@ghostprotocols.net>
References: <1304066518-30420-1-git-send-email-ming.m.lin@intel.com>
	 <1304066518-30420-2-git-send-email-ming.m.lin@intel.com>
	 <20110429173332.GA3273@ghostprotocols.net>
Content-Type: text/plain; charset="UTF-8"
Date: Sat, 30 Apr 2011 12:14:54 +0800
Message-Id: <1304136894.3761.1.camel@localhost>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1341
Lines: 40

On Sat, 2011-04-30 at 01:33 +0800, Arnaldo Carvalho de Melo wrote:
> Em Fri, Apr 29, 2011 at 08:41:57AM +0000, Lin Ming escreveu:
> > pubname_callback_param::found should be initialized to 0 in fastpath lookup.
> 
> 
> Is this really needed? Or is this just to stress it, for documentational
> purposes?

Yes, this is really needed.

It should be initialized to 0, and pubname_search_cb will set it to 1 if
the function is found.

>  
> > Signed-off-by: Lin Ming <ming.m.lin@intel.com>
> > ---
> >  tools/perf/util/probe-finder.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c
> > index a7c7145..3b9d0b8 100644
> > --- a/tools/perf/util/probe-finder.c
> > +++ b/tools/perf/util/probe-finder.c
> > @@ -1538,6 +1538,7 @@ static int find_probes(int fd, struct probe_finder *pf)
> >  			.file	  = pp->file,
> >  			.cu_die	  = &pf->cu_die,
> >  			.sp_die	  = &pf->sp_die,
> > +			.found	  = 0,
> >  		};
> >  		struct dwarf_callback_param probe_param = {
> >  			.data = pf,
> > -- 
> > 1.7.4.4


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/