Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754802Ab1D3FKB (ORCPT ); Sat, 30 Apr 2011 01:10:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43150 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753181Ab1D3FKA (ORCPT ); Sat, 30 Apr 2011 01:10:00 -0400 Date: Sat, 30 Apr 2011 01:09:51 -0400 From: Dave Jones To: Greg KH Cc: Andrew Morton , Jan Kara , LKML Subject: Re: Allow setting of number of raw devices as a module parameter Message-ID: <20110430050951.GA16557@redhat.com> Mail-Followup-To: Dave Jones , Greg KH , Andrew Morton , Jan Kara , LKML References: <1304029469-19672-1-git-send-email-jack@suse.cz> <20110429162817.2eb26efb.akpm@linux-foundation.org> <20110430000704.GA3443@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110430000704.GA3443@suse.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1346 Lines: 31 On Fri, Apr 29, 2011 at 05:07:04PM -0700, Greg KH wrote: > On Fri, Apr 29, 2011 at 04:28:17PM -0700, Andrew Morton wrote: > > On Fri, 29 Apr 2011 00:24:29 +0200 > > Jan Kara wrote: > > > > > Allow setting of maximal number of raw devices as a module parameter. This > > > requires changing of static array into a vmalloced one (the array is going to > > > be too large for kmalloc). > > > > > > > Changelog failed to describe why the patch is needed. Lacking that > > information, we have no reason to apply it. > > Good point, how about: > People like running their machines with thousands of raw > devices, yet distros don't want to take up that much memory for > all users. Provide a way for everyone to be happy without > forcing the module to be rebuilt by providing the ability to > specify the number of raw devices as a module parameter option. I remember when this was made a config option, thinking "8192 raw devices? who would need that many?". I have to wonder just how someone manages a system with an insane number of these devices. Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/