From: Arnd Bergmann <arnd@arndb.de>
To: Jan Kara <jack@suse.cz>
Subject: Re: Allow setting of number of raw devices as a module parameter
Date: Sat, 30 Apr 2011 14:15:02 +0200
User-Agent: KMail/1.13.5 (Linux/2.6.39-rc4+; KDE/4.5.1; x86_64; ; )
Cc: LKML <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
References: <1304029469-19672-1-git-send-email-jack@suse.cz>
In-Reply-To: <1304029469-19672-1-git-send-email-jack@suse.cz>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201104301415.02349.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 889
Lines: 21

On Friday 29 April 2011 00:24:29 Jan Kara wrote:
> Allow setting of maximal number of raw devices as a module parameter. This
> requires changing of static array into a vmalloced one (the array is going to
> be too large for kmalloc).
> 
> Signed-off-by: Jan Kara <jack@suse.cz>

Why don't you get rid of the global raw_devices array instead?

I suppose if you embed the struct cdev in raw_device_data and
register it during RAW_SETBIND separately for each raw device
instead of globally at raw_init time, you can support any number
of devices while making the code smaller and simpler. I suppose
you can even remove the raw_mutex then.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/