Date: Sat, 30 Apr 2011 16:58:11 -0400 (EDT)
From: Vince Weaver <vweaver1@eecs.utk.edu>
To: Ingo Molnar <mingo@elte.hu>
cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Stephane Eranian <eranian@gmail.com>, Andi Kleen <ak@linux.intel.com>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: re-enable Nehalem raw Offcore-Events support
In-Reply-To: <alpine.DEB.2.00.1104292149480.9459@cl320.eecs.utk.edu>
Message-ID: <alpine.DEB.2.00.1104301653310.7288@cl320.eecs.utk.edu>
References: <alpine.DEB.2.00.1104291056220.22212@cl320.eecs.utk.edu> <20110429164227.GA25491@elte.hu> <alpine.DEB.2.00.1104292149480.9459@cl320.eecs.utk.edu>
User-Agent: Alpine 2.00 (DEB 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1839
Lines: 42

On Fri, 29 Apr 2011, Vince Weaver wrote:

> >    https://lkml.org/lkml/2011/4/22/281
> > 
> 
> So here's my review:
>  NACK

so a slightly more useful review on slightly more sleep.

You are doing things backwards with your "generalization first" policy.

The right way to do things is enable raw event support first.

Then you can have users experiment with the feature.  Try various events 
using their favorite userspace utility (be it libpfm4, PAPI, perf).  This 
is easy, as choosing a new event is a simple matter of changing the 
command line option for your measurement.  Once a good event is found for 
generalization, *THEN* you add a generalized event that is well tested.

Your way is difficult.  Fine, Peter picks some arbitrary event he thinks 
work well.  I have to download a git kernel and reboot my machine (a 
process that takes an hour at best assuming I have root access).  Then if 
I want to try a new event, since RAW access is blocked, I have to patch 
the kernel, recompile, reboot.  So at least an hour between tests.

This assumes I can even do that.  My only Nehalem machine is at work and 
has only a fragile wireless network connection that requires manual 
intervention to get going.  so I *can't* review a change in general events 
with a remove access when it lives in the kernel, yet if it was in user 
space like it *should be* I could test away all day no problem.

See the problem here?  Going general event first makes it seriously 
inconvenient to test and so noone is going to do it for you because it's 
such a pain.  RAW first is the way to go.

Vince
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/