Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753050Ab1EANNd (ORCPT ); Sun, 1 May 2011 09:13:33 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:33182 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751115Ab1EANNc (ORCPT ); Sun, 1 May 2011 09:13:32 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 From: KOSAKI Motohiro To: Johannes Weiner Subject: Re: [RFC 4/8] Make clear description of putback_lru_page Cc: kosaki.motohiro@jp.fujitsu.com, Minchan Kim , KAMEZAWA Hiroyuki , Andrew Morton , linux-mm , LKML , Christoph Lameter , Johannes Weiner , Mel Gorman , Rik van Riel , Andrea Arcangeli In-Reply-To: <20110428084500.GG12437@cmpxchg.org> References: <20110428084500.GG12437@cmpxchg.org> Message-Id: <20110501221459.75E4.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.56.05 [ja] Date: Sun, 1 May 2011 22:13:28 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1677 Lines: 45 > On Thu, Apr 28, 2011 at 08:20:32AM +0900, Minchan Kim wrote: > > On Wed, Apr 27, 2011 at 5:11 PM, KAMEZAWA Hiroyuki > > wrote: > > > On Wed, 27 Apr 2011 01:25:21 +0900 > > > Minchan Kim wrote: > > > > > >> Commonly, putback_lru_page is used with isolated_lru_page. > > >> The isolated_lru_page picks the page in middle of LRU and > > >> putback_lru_page insert the lru in head of LRU. > > >> It means it could make LRU churning so we have to be very careful. > > >> Let's clear description of putback_lru_page. > > >> > > >> Cc: KOSAKI Motohiro > > >> Cc: Mel Gorman > > >> Cc: Rik van Riel > > >> Cc: Andrea Arcangeli > > >> Signed-off-by: Minchan Kim > > > > > > seems good... > > > Reviewed-by: KAMEZAWA Hiroyuki > > > > > > But is there consensus which side of LRU is tail? head? > > > > I don't know. I used to think it's head. > > If other guys raise a concern as well, let's talk about it. :) > > Thanks > > I suppose we add new pages to the head of the LRU and reclaim old > pages from the tail. > > Acked-by: Johannes Weiner So, It would be better if isolate_lru_page() also have "LRU tail blah blah blah" comments. anyway, Reviewed-by: KOSAKI Motohiro -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/