Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755090Ab1EAPET (ORCPT ); Sun, 1 May 2011 11:04:19 -0400 Received: from mail-pv0-f174.google.com ([74.125.83.174]:54857 "EHLO mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754776Ab1EAPDz (ORCPT ); Sun, 1 May 2011 11:03:55 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=PSmaV/Sffj5BY83u32gSe2a0vt3fA0K4ALpvj8LWq7tAsQDDdH/+Vmiwj8Q+C9lwbC /hKWLdsoLHAg7iHdWXgIWj+4jg60yhv/r6rXm5Ps70G4A7T1JLAx9AU3XNEU0IzL0BKN z/jB7DIkUsODGrUtExptdTkxQbR6SPx2+mS+E= From: Minchan Kim To: Andrew Morton Cc: linux-mm , LKML , KAMEZAWA Hiroyuki , Johannes Weiner , Rik van Riel , KOSAKI Motohiro , Mel Gorman , Ying Han , Minchan Kim Subject: [PATCH 1/2] Check PageUnevictable in lru_deactivate_fn Date: Mon, 2 May 2011 00:03:30 +0900 Message-Id: X-Mailer: git-send-email 1.7.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1027 Lines: 34 The lru_deactivate_fn should not move page which in on unevictable lru into inactive list. Otherwise, we can meet BUG when we use isolate_lru_pages as __isolate_lru_page could return -EINVAL. It's really BUG and let's fix it. Reported-by: Ying Han Tested-by: Ying Han Signed-off-by: Minchan Kim --- mm/swap.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/mm/swap.c b/mm/swap.c index a83ec5a..2e9656d 100644 --- a/mm/swap.c +++ b/mm/swap.c @@ -429,6 +429,9 @@ static void lru_deactivate_fn(struct page *page, void *arg) if (!PageLRU(page)) return; + if (PageUnevictable(page)) + return; + /* Some processes are using the page */ if (page_mapped(page)) return; -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/