Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755928Ab1EAPEW (ORCPT ); Sun, 1 May 2011 11:04:22 -0400 Received: from mail-pw0-f46.google.com ([209.85.160.46]:49587 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754862Ab1EAPEA (ORCPT ); Sun, 1 May 2011 11:04:00 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=SpkaxOqtSy3bEbRkkFccJBZB8+U+auO0HSdKSi1+idfpVs8eAt/ODfiVrpNf/4EnsY jyAU8SoVxgT8tAGWBMZ64NZKKAM69X6vnWIRjxIW0ljKiKfeV7LRO+fHR5pD8XfZECof BxHqjY93vGWwxOaedLEyAdyhviht/8SV7B6TE= From: Minchan Kim To: Andrew Morton Cc: linux-mm , LKML , KAMEZAWA Hiroyuki , Johannes Weiner , Rik van Riel , KOSAKI Motohiro , Mel Gorman , Ying Han , Minchan Kim Subject: [PATCH 2/2] Filter unevictable page out in deactivate_page Date: Mon, 2 May 2011 00:03:31 +0900 Message-Id: X-Mailer: git-send-email 1.7.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1148 Lines: 38 It's pointless that deactive_page's pagevec operation about unevictable page as it's nop. This patch removes unnecessary overhead which might be a bit problem in case that there are many unevictable page in system(ex, mprotect workload) Signed-off-by: Minchan Kim --- mm/swap.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/mm/swap.c b/mm/swap.c index 2e9656d..b707694 100644 --- a/mm/swap.c +++ b/mm/swap.c @@ -511,6 +511,15 @@ static void drain_cpu_pagevecs(int cpu) */ void deactivate_page(struct page *page) { + + /* + * In workload which system has many unevictable page(ex, mprotect), + * unevictalge page deactivation for accelerating reclaim + * is pointless. + */ + if (PageUnevictable(page)) + return; + if (likely(get_page_unless_zero(page))) { struct pagevec *pvec = &get_cpu_var(lru_deactivate_pvecs); -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/