Date: Mon, 2 May 2011 17:27:02 +0200
From: Samuel Ortiz <sameo@linux.intel.com>
To: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
Cc: linux-kernel@vger.kernel.org, broonie@opensource.wolfsonmicro.com,
        lrg@ti.com, Graeme Gregory <gg@slimlogic.co.uk>
Subject: Re: [PATCHv5 1/4] MFD: TPS65910: Add new mfd device for TPS65910
Message-ID: <20110502152701.GG8222@sortiz-mobl>
References: <C3F379CD-4C84-4E7F-BD6F-078E04F15F65@slimlogic.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <C3F379CD-4C84-4E7F-BD6F-078E04F15F65@slimlogic.co.uk>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1017
Lines: 33

Hi Jorge,

On Wed, Apr 27, 2011 at 10:51:00AM -0500, Jorge Eduardo Candelaria wrote:
> From: Graeme Gregory <gg@slimlogic.co.uk>
> 
> The TPS65910 chip is a power management IC for multimedia and handheld
> devices. It contains the following components:
> 
> - Regulators
> - GPIO controller
> - RTC
> 
> The tps65910 core driver is registered as a platform driver and provides
> communication through I2C with the host device for the different
> components.
I'm going to be picky here:

> +static DEFINE_MUTEX(io_mutex);
Having this mutex in the tps65910 structure would be cleaner. I know the
likeliness of having 2 of those devices in one system is very low, but still,
it would be nicer.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/