Date: Mon, 2 May 2011 21:39:37 +0200
From: Jan Kara <jack@suse.cz>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Jan Kara <jack@suse.cz>, LKML <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: Allow setting of number of raw devices as a module parameter
Message-ID: <20110502193937.GM4556@quack.suse.cz>
References: <1304029469-19672-1-git-send-email-jack@suse.cz>
 <201104301415.02349.arnd@arndb.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201104301415.02349.arnd@arndb.de>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1254
Lines: 29

On Sat 30-04-11 14:15:02, Arnd Bergmann wrote:
> On Friday 29 April 2011 00:24:29 Jan Kara wrote:
> > Allow setting of maximal number of raw devices as a module parameter. This
> > requires changing of static array into a vmalloced one (the array is going to
> > be too large for kmalloc).
> > 
> > Signed-off-by: Jan Kara <jack@suse.cz>
> 
> Why don't you get rid of the global raw_devices array instead?
> 
> I suppose if you embed the struct cdev in raw_device_data and
> register it during RAW_SETBIND separately for each raw device
> instead of globally at raw_init time, you can support any number
> of devices while making the code smaller and simpler. I suppose
> you can even remove the raw_mutex then.
  OK, I see. This might be a reasonable option. I'd then use kobj_lookup()
to find my structure where I need it instead of array indexing, right? 
I have really zero experience with writing device drivers so I'm asking
simple questions :).

								Honza
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/