DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=yahoo.com;
  h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding;
  b=bfWu47QAAvowpwYPZlXtCF2Bu4/l5yeg8ofAEMD69SZWIu2nonXqQq0TqkxSt377JLXJUUaQpnSbtk81+rZcABFe2IrtMxJdaXrQkmaLTbqqp5SHLkpDicTb9BavJiotgJKFyYugNn4mb39iBwFF6gVA+HqR+1zQaLe8j0+KT9c=;
Message-ID: <325376.71935.qm@web29015.mail.ird.yahoo.com>
Date: Mon, 2 May 2011 23:16:23 +0100 (BST)
From: Paul Parsons <lost.distance@yahoo.com>
Subject: Re: [PATCH 1/2] mfd: Add ASIC3 LED support
To: Samuel Ortiz <sameo@linux.intel.com>
Cc: linux-kernel@vger.kernel.org
In-Reply-To: <20110502153951.GH8222@sortiz-mobl>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 991
Lines: 26

Hi Samuel,

--- On Mon, 2/5/11, Samuel Ortiz <sameo@linux.intel.com> wrote:
> Where is the LED driver ?
It was posted separately - [PATCH 2/2] leds: Add ASIC3 LED support - since drivers/mfd and drivers/leds are maintained separately. Sorry, I should have cross copied them.

> > -static int asic3_clk_enable(struct asic3 *asic,
> struct asic3_clk *clk)
> > +static void asic3_clk_enable(struct asic3 *asic,
> struct asic3_clk *clk)
> Although a valid change, this is unrelated to this patch.
Not completely unrelated; I call asic3_clk_enable() and found it simpler to remove the unnecessary return value rather than check it.

> > +??? asic->gpio.label = "asic3";
> Ditto.
Agreed; that was left in by mistake.

Should I resubmit?

Regards,
Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/