Date: Mon, 2 May 2011 15:19:59 -0700
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Josh Triplett <josh@joshtriplett.org>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, laijs@cn.fujitsu.com,
        dipankar@in.ibm.com, akpm@linux-foundation.org,
        mathieu.desnoyers@polymtl.ca, niv@us.ibm.com, tglx@linutronix.de,
        peterz@infradead.org, rostedt@goodmis.org, Valdis.Kletnieks@vt.edu,
        dhowells@redhat.com, eric.dumazet@gmail.com, darren@dvhart.com,
        patches@linaro.org, "Paul E. McKenney" <paul.mckenney@linaro.org>
Subject: Re: [PATCH tip/core/rcu 11/86] rcu: Add boosting to
 TREE_PREEMPT_RCU tracing
Message-ID: <20110502221959.GK2294@linux.vnet.ibm.com>
Reply-To: paulmck@linux.vnet.ibm.com
References: <20110501132142.GA25494@linux.vnet.ibm.com>
 <1304256126-26015-11-git-send-email-paulmck@linux.vnet.ibm.com>
 <20110501155225.GF14829@feather>
 <20110502082711.GW2297@linux.vnet.ibm.com>
 <20110502175357.GE24574@feather>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110502175357.GE24574@feather>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1676
Lines: 33

On Mon, May 02, 2011 at 10:53:57AM -0700, Josh Triplett wrote:
> On Mon, May 02, 2011 at 01:27:11AM -0700, Paul E. McKenney wrote:
> > On Sun, May 01, 2011 at 08:52:25AM -0700, Josh Triplett wrote:
> > > On Sun, May 01, 2011 at 06:20:51AM -0700, Paul E. McKenney wrote:
> > > > From: Paul E. McKenney <paul.mckenney@linaro.org>
> > > > 
> > > > Includes total number of tasks boosted, number boosted on behalf of each
> > > > of normal and expedited grace periods, and statistics on attempts to
> > > > initiate boosting that failed for various reasons.
> > > 
> > > In this patch series, you have several cases where you improve the trace
> > > output in one patch, and then update the documentation in a subsequent
> > > patch.  You might consider doing both in the same patch, so that at each
> > > step the documentation matches the kernel.
> > 
> > The reason I do the documentation second is that it allows me to copy
> > the exact output from a test run, which has the nice side-effect of
> > making sure that I really am getting the documentation correct.  Or at
> > least of reducing the probability of getting it wrong...  ;-)
> 
> I definitely agree that you should copy the output from a test run to
> make the documentation accurate; I just mean that once you do so, you
> should put both the code changes and corresponding documentation into a
> single commit.

Fair enough, I did some squashing.

							Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/