Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752949Ab1ECGpY (ORCPT ); Tue, 3 May 2011 02:45:24 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:47005 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751485Ab1ECGpW (ORCPT ); Tue, 3 May 2011 02:45:22 -0400 Date: Tue, 3 May 2011 08:45:05 +0200 From: Ingo Molnar To: Borislav Petkov Cc: Peter Zijlstra , Arnaldo Carvalho de Melo , Steven Rostedt , Frederic Weisbecker , Tony Luck , Mauro Carvalho Chehab , EDAC devel , LKML , Borislav Petkov Subject: Re: [PATCH 4/4] x86, mce: Have MCE persistent event off by default for now Message-ID: <20110503064505.GF7751@elte.hu> References: <1304357691-14354-1-git-send-email-bp@amd64.org> <1304357691-14354-5-git-send-email-bp@amd64.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1304357691-14354-5-git-send-email-bp@amd64.org> User-Agent: Mutt/1.5.20 (2009-08-17) X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.3.1 -2.0 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1264 Lines: 33 * Borislav Petkov wrote: > From: Borislav Petkov > > This is new functionality and it affects all of x86 so we want to be > very conservative about it and have it off by default for now, in case > something goes awry. You can always enable it by supplying "ras" on the > kernel command line. > > Also, depending on whether it is enabled or not, we emit the tracepoint > from a different place in the code to pick up additional decoded info. > > Signed-off-by: Borislav Petkov > --- > Documentation/kernel-parameters.txt | 2 ++ > arch/x86/include/asm/mce.h | 1 + > arch/x86/kernel/cpu/mcheck/mce.c | 32 ++++++++++++++++++++++++++++++-- > drivers/edac/mce_amd.c | 5 +++++ > 4 files changed, 38 insertions(+), 2 deletions(-) the boot flag is fine - but please keep it enabled by default if MCE support is enabled in the .config, we do not chicken out when it comes to testing new code! :-) Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/