Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752024Ab1ECJgE (ORCPT ); Tue, 3 May 2011 05:36:04 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:47331 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751406Ab1ECJgC (ORCPT ); Tue, 3 May 2011 05:36:02 -0400 Date: Tue, 3 May 2011 10:37:04 +0100 From: Alan Cox To: Jimmy Chen (=?big5?B?s6+lw7lG?=) Cc: , , Subject: Re: [PATCH 2/2] watchdog: add support for MOXA V2100 watchdog driver Message-ID: <20110503103704.69aba5b2@lxorguk.ukuu.org.uk> In-Reply-To: References: X-Mailer: Claws Mail 3.7.8 (GTK+ 2.22.0; x86_64-redhat-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEWysKsSBQMIAwIZCwj///8wIhxoRDXH9QHCAAABeUlEQVQ4jaXTvW7DIBAAYCQTzz2hdq+rdg494ZmBeE5KYHZjm/d/hJ6NfzBJpp5kRb5PHJwvMPMk2L9As5Y9AmYRBL+HAyJKeOU5aHRhsAAvORQ+UEgAvgddj/lwAXndw2laEDqA4x6KEBhjYRCg9tBFCOuJFxg2OKegbWjbsRTk8PPhKPD7HcRxB7cqhgBRp9Dcqs+B8v4CQvFdqeot3Kov6hBUn0AJitrzY+sgUuiA8i0r7+B3AfqKcN6t8M6HtqQ+AOoELCikgQSbgabKaJW3kn5lBs47JSGDhhLKDUh1UMipwwinMYPTBuIBjEclSaGZUk9hDlTb5sUTYN2SFFQuPe4Gox1X0FZOufjgBiV1Vls7b+GvK3SU4wfmcGo9rPPQzgIabfj4TYQo15k3bTHX9RIw/kniir5YbtJF4jkFG+dsDK1IgE413zAthU/vR2HVMmFUPIHTvF6jWCpFaGw/A3qWgnbxpSm9MSmY5b3pM1gvNc/gQfwBsGwF0VCtxZgAAAAASUVORK5CYII= Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 994 Lines: 33 > Add real function for watchdog driver Looks a lot better > +#define __KERNEL_SYSCALLS__ > + You shouldn't need that define now > + /* we suppose to check magic id in case wrong devices */ > + if (wdt_verify_vendor()) { > + printk(KERN_ERR "hw device id not match!!\n"); > + ret = -ENODEV; > + goto reqreg_err; > + } This wants to happen after the request_region - if the region is busy then you know your device isn't present but that the addresses in question are currently in use so you shouldn't touch them We tend to use pr_err()/pr_debug() etc now rather than printk(KERN_ERR "Oops"); to be less long winded - but the code you have there isn't wrong in using printk(). With the tests re-ordered this looks fairly sound to me Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/