From: Arnd Bergmann <arnd@arndb.de>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH 2/2] watchdog: add support for MOXA V2100 watchdog driver
Date: Tue, 3 May 2011 14:51:56 +0200
User-Agent: KMail/1.12.2 (Linux/2.6.37; KDE/4.3.2; x86_64; ; )
Cc: Wolfram Sang <w.sang@pengutronix.de>, jimmy.chen@moxa.com,
        linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
        wim@iguana.be
References: <20110503103704.69aba5b2@lxorguk.ukuu.org.uk> <20110503105735.GB2497@pengutronix.de> <20110503121510.5bba70c5@lxorguk.ukuu.org.uk>
In-Reply-To: <20110503121510.5bba70c5@lxorguk.ukuu.org.uk>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201105031451.56911.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1149
Lines: 26

On Tuesday 03 May 2011, Alan Cox wrote:
> > Hmm, code in a header? Can't this go into the main source? Hmm, at least
> > it87_wdt.c has something very similar. Maybe it can even be shared? What
> > about locking BTW?
> 
> The spinlock handles it if you look at the caller points, because you
> have to own the super I/O and select it each time.

I suppose the functions should at least be 'static inline' so they avoid
polluting the global namespace.

> Ultimately it wants to be using request_muxed_* but that isn't in any of
> the mainstream code yet so can be done in the future when the mux patches
> go in.

Another thing that might be nice here is to have one module that probes
the superio-port and then registers a platform device that other drivers
can can bind to. Right now, you have to load the module manually and
then check if it's there, something we no longer do for most devices.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/