From: Arnd Bergmann <arnd@arndb.de>
To: Omar Ramirez Luna <omar.ramirez@ti.com>
Subject: Re: [PATCH v4 0/6] staging tidspbridge: iommu migration
Date: Tue, 3 May 2011 22:18:29 +0200
User-Agent: KMail/1.13.5 (Linux/2.6.39-rc4+; KDE/4.5.1; x86_64; ; )
Cc: "Greg Kroah-Hartman" <gregkh@suse.de>,
        Felipe Contreras <felipe.contreras@gmail.com>,
        Fernando Guzman Lugo <x0095840@ti.com>,
        "Ohad Ben-Cohen" <ohad@wizery.com>, Nishanth Menon <nm@ti.com>,
        lkml <linux-kernel@vger.kernel.org>,
        devel <devel@driverdev.osuosl.org>
References: <1304004712-8487-1-git-send-email-omar.ramirez@ti.com>
In-Reply-To: <1304004712-8487-1-git-send-email-omar.ramirez@ti.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201105032218.29592.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 958
Lines: 23

On Thursday 28 April 2011 17:31:46 Omar Ramirez Luna wrote:
> Rework and rebase of the previous set of patches for iommu migration[1].
> 
> Reorganized the patches to avoid several iterations to change the same code.
> 
> Patches were tested with an OMAP3630 board, with both, basic samples and
> gst-dsp; these are dependant on patch:
>         "OMAP: iovmm: fix SW flags passed by user"[2].

The code removal in this series looks good, but the move from
one proprietary iommu API to another proprietary iommu API
seems pointless.

It would be much more helpful if you could convert the tidspbridge
code to the dma-mapping API, or to the generic iommu API
and provide these interfaces from the omap code.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/