Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755276Ab1EDDke (ORCPT ); Tue, 3 May 2011 23:40:34 -0400 Received: from mail-qw0-f46.google.com ([209.85.216.46]:51192 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755042Ab1EDDk0 (ORCPT ); Tue, 3 May 2011 23:40:26 -0400 Date: Tue, 3 May 2011 23:40:23 -0400 (EDT) From: Nicolas Pitre X-X-Sender: nico@xanadu.home To: Per Forlin cc: linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, lkml , linaro-dev@lists.linaro.org, Stefan Nilsson XK Subject: Re: [PATCH] sdio: optimized SDIO IRQ handling for single function In-Reply-To: <1304453087-7365-1-git-send-email-per.forlin@linaro.org> Message-ID: References: <1304453087-7365-1-git-send-email-per.forlin@linaro.org> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1883 Lines: 56 On Tue, 3 May 2011, Per Forlin wrote: > From: Stefan Nilsson XK > > If there is only 1 function registered, and IRQ:s are supported and > currently enabled, call the callback handler directly > without checking the CCCR registers. > > Signed-off-by: Stefan Nilsson XK > Signed-off-by: Per Forlin Acked-by: Nicolas Pitre > --- > drivers/mmc/core/sdio_irq.c | 14 ++++++++++++++ > 1 files changed, 14 insertions(+), 0 deletions(-) > > diff --git a/drivers/mmc/core/sdio_irq.c b/drivers/mmc/core/sdio_irq.c > index b300161..25291bf 100644 > --- a/drivers/mmc/core/sdio_irq.c > +++ b/drivers/mmc/core/sdio_irq.c > @@ -32,6 +32,20 @@ static int process_sdio_pending_irqs(struct mmc_card *card) > int i, ret, count; > unsigned char pending; > > + /* > + * If there is only 1 function registered > + * call irq directly without checking the CCCR registers. > + */ > + if ((card->host->caps & MMC_CAP_SDIO_IRQ) && > + card->host->sdio_irqs && (card->sdio_funcs == 1)) > + for (i = 0; i < SDIO_MAX_FUNCS; i++) { > + struct sdio_func *func = card->sdio_func[i]; > + if (func && func->irq_handler) { > + func->irq_handler(func); > + return 1; > + } > + } > + > ret = mmc_io_rw_direct(card, 0, 0, SDIO_CCCR_INTx, 0, &pending); > if (ret) { > printk(KERN_DEBUG "%s: error %d reading SDIO_CCCR_INTx\n", > -- > 1.7.4.1 > > > _______________________________________________ > linaro-dev mailing list > linaro-dev@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/linaro-dev > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/